Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress.
report-to
aims to replacereport-uri
in CSP 3 but it only has support in certain browsers (chrome and android > v70).Basically what is missing from this PR is a rule in Joi that supports the desired behaviour and add it in schema.
So we want to have the following different rules:
use report-only only when report-uri is present (as we currently have):
schema.with('reportOnly', 'reportUri');
same as before, but for report-to (when reportTo replaces reportUri):
schema.with('reportOnly', 'reportTo');
we can also have both
reportUri
andreportTo
and the browser will decide which one to useSomething like
schema.with('reportOnly', ['reportUri', 'reportTo']);
or using object.orschema.or(schema.with('reportOnly', 'reportUri'), schema.with('reportOnly', 'reportTo'))
I couldn't find a way to properly do it in Joi. @nlf do you know if it is possible in any way?