Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix/module.nix: Start comin after the network comes up #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpds
Copy link
Contributor

@jpds jpds commented May 3, 2024

No description provided.

@jpds jpds force-pushed the after-network branch from 0e155dc to 3471c45 Compare May 3, 2024 13:26
@nlewo
Copy link
Owner

nlewo commented May 5, 2024

If you add a local remote, comin could fetch new commit without having to rely on the network.
Moreover, since comin polls periodically, i don't think it's an issue if it starts before the network: comin could fail on first iterations but then succeeds once the network it up.

So, i'm not in favor of adding such dependency.

What kind of issue did you encounter exactly?

@jpds
Copy link
Contributor Author

jpds commented May 5, 2024

It started up very early in my boot sequence (way before networkd and unbound) - and thus failed a bunch of times on DNS requests.

Even with a local remote, users will probably still need network connectivity to pull down the sources/cache.

I might just override this locally on all my boxes.

@jpds jpds force-pushed the after-network branch from 3471c45 to 8c9952a Compare May 7, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants