🐛fix test failed on Windows #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace `filepath` with `path`
nlepage
approved these changes
Sep 13, 2021
|
Thank you! |
rohansingh
added a commit
to tidbyt/pixlet
that referenced
this pull request
Apr 24, 2024
It appears that `nlepage/go-tarfs` correctly supports Windows by [using `path` instead of `filepath`][1]. [1]: nlepage/go-tarfs#7
rohansingh
added a commit
to tidbyt/pixlet
that referenced
this pull request
Apr 24, 2024
* Add the ability to read files from Starlark
Starlark scripts can now load arbitrary files from their bundle and read
them using a Python-like `open()` and `read()` API. A `readall()`
convenience function is also provided.
The examples have been updated to use this functionality where relevant.
For example:
```
load("icon.png", icon = "file")
BTC_ICON = icon.readall()
```
The `pixlet render` command can now accept an entire directory
containing multiple Starlark files and static resources.
* Remove `file.open` and `read()`
Remove the `open()` and `read()` functions, so the only way to read a
file is `readall()`.
If there is demand for the other methods, we can add them back later.
* Add directory support to `pixlet serve`
* Implement `pixlet bundle` for directories
* Fix path problems on Windows
`fs.FS` always uses slash-separated paths, even on Windows. So we should
be manipulating those paths with `path`, not `filepath`.
* Switch tarfs implementations for Windows support
It appears that `nlepage/go-tarfs` correctly supports Windows by [using
`path` instead of `filepath`][1].
[1]: nlepage/go-tarfs#7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
filepathwithpath