ci: disable no-unused-vars in TypeScript

TypeScript checks that already, and does it better
nl-design-system · Aug 4, 2024 · fb59ab8 · fb59ab8
1 parent 59c885e
commit fb59ab8
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 5 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -44,13 +44,25 @@ module.exports = {
       plugins: ['import', 'jest'],
     },
     {
-      extends: ['plugin:react/recommended', 'eslint-config-prettier', './.eslintrc.js.json', './.eslintrc.react.json'],
+      extends: [
+        'plugin:react/recommended',
+        'eslint-config-prettier',
+        './.eslintrc.js.json',
+        './.eslintrc.react.json',
+        './.eslintrc.ts.json',
+      ],
       files: ['*.ts', '*.tsx'],
       parser: '@typescript-eslint/parser',
       plugins: ['@typescript-eslint', 'import', 'jest'],
     },
     {
-      extends: ['plugin:react/recommended', 'eslint-config-prettier', './.eslintrc.js.json', './.eslintrc.react.json'],
+      extends: [
+        'plugin:react/recommended',
+        'eslint-config-prettier',
+        './.eslintrc.js.json',
+        './.eslintrc.react.json',
+        './.eslintrc.ts.json',
+      ],
       files: ['**/stencil.tsx', '**/*.stencil.tsx'],
       parser: '@typescript-eslint/parser',
       parserOptions: {
@@ -60,7 +72,7 @@ module.exports = {
     },
     {
       excludedFiles: ['**/stencil.tsx', '**/*.stencil.tsx'],
-      extends: ['plugin:react/recommended', 'eslint-config-prettier', './.eslintrc.js.json'],
+      extends: ['plugin:react/recommended', 'eslint-config-prettier', './.eslintrc.js.json', './.eslintrc.ts.json'],
       files: ['*.ts', '*.tsx'],
       parser: '@typescript-eslint/parser',
       parserOptions: {

diff --git a/.eslintrc.ts.json b/.eslintrc.ts.json
@@ -0,0 +1,5 @@
+{
+  "rules": {
+    "no-unused-vars": "off"
+  }
+}
diff --git a/packages/component-library-react/src/Calendar/index.tsx b/packages/component-library-react/src/Calendar/index.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable no-unused-vars */
 import {
   addMonths,
   addWeeks,

diff --git a/packages/component-library-react/src/IndexCharNav.tsx b/packages/component-library-react/src/IndexCharNav.tsx
@@ -21,7 +21,7 @@ export interface IndexCharNavProps {
    * }
    *```
    */
-  // eslint-disable-next-line no-unused-vars
+
   onLinkClick?: (char: string) => void;
   /**
    * The current char.
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,7 +21,7 @@ export interface IndexCharNavProps { @@
        * }
        *```
        */
-      // eslint-disable-next-line no-unused-vars
       onLinkClick?: (char: string) => void;
       /**
        * The current char.
@@ Expand Down @@