Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add color sample tokens #916

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Marwaxhello
Copy link
Contributor

@Marwaxhello Marwaxhello commented Jan 7, 2025

Pull Request Color Sample

Screenshot 2025-01-07 at 14 50 51

In deze PR heb ik color-sample tokens toegevoegd aan de Theme Builder in het Purmerend-thema.

  • color-sample-default
  • color-sample-dark
  • color-sample-light

Hoe bepaal ik welke tokens ik moet gebruiken voor elke color-sample-variant? In de documentatie van Utrecht vind je onderaan de pagina een overzicht van alle gebruikte tokens voor een specifieke component, inclusief de verschillende staten van die component. Dit maakt het gemakkelijk om de juiste tokens te identificeren.

@Marwaxhello Marwaxhello requested a review from a team as a code owner January 7, 2025 13:58
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
themes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 4:11pm

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (e367b8d) to head (adfb236).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   89.72%   89.72%           
=======================================
  Files          19       19           
  Lines        1363     1363           
  Branches      177      181    +4     
=======================================
  Hits         1223     1223           
  Misses        139      139           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marwaxhello Marwaxhello force-pushed the feat/component-story-tokens-color-sample branch from e034095 to 833bf45 Compare January 9, 2025 14:04
@Marwaxhello Marwaxhello force-pushed the feat/component-story-tokens-color-sample branch from 833bf45 to adfb236 Compare January 9, 2025 14:43
@Robbert Robbert merged commit 17b333d into main Jan 9, 2025
1 of 3 checks passed
@Robbert Robbert deleted the feat/component-story-tokens-color-sample branch January 9, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants