Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable tokens studio transform group for voorbeeld thema #862

Merged

Conversation

bddjong
Copy link
Contributor

@bddjong bddjong commented Dec 16, 2024

Result

This fixes the units but note that it does also transform the format of a few other tokens. Scroll down for more. Three test results had to have their expected output (a color hex) changed to lower case instead of upper case due to this. See the last commit.

Line heights

Diff

-  --voorbeeld-typography-line-height-lg: 200%;
+  --voorbeeld-typography-line-height-lg: 2;

Colors with transparent or alpha

Diff

-  --utrecht-accordion-button-active-border-color: transparent;
-  --voorbeeld-color-dark-alpha-100: #0000001a;
+  --utrecht-accordion-button-active-border-color: rgba(0, 0, 0, 0);
+  --voorbeeld-color-dark-alpha-100: rgba(0, 0, 0, 0.1);

Font family notation

Diff

-  --voorbeeld-typography-font-family-code: Fira Code, Tahoma, Verdana, sans-serif;
+  --voorbeeld-typography-font-family-code: 'Fira Code', Tahoma, Verdana, sans-serif;

@bddjong bddjong requested a review from a team as a code owner December 16, 2024 11:32
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
themes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 11:07am

@Robbert
Copy link
Member

Robbert commented Dec 16, 2024

Ik vind dit een goed idee, als dit problemen oplevert mogen mensen bij mij klagen!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (3663d08) to head (417d8cf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #862   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files          19       19           
  Lines        1334     1334           
  Branches      167      178   +11     
=======================================
  Hits         1194     1194           
  Misses        139      139           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bddjong bddjong force-pushed the build/enable-tokens-studio-transform-group-voorbeeld-thema branch from 417d8cf to ec1d814 Compare December 16, 2024 16:52
Robbert
Robbert previously approved these changes Dec 18, 2024
@Robbert Robbert force-pushed the build/enable-tokens-studio-transform-group-voorbeeld-thema branch from ec1d814 to 5977211 Compare December 18, 2024 10:59
Robbert
Robbert previously approved these changes Dec 18, 2024
@Robbert Robbert enabled auto-merge (rebase) December 18, 2024 11:00
@Robbert Robbert disabled auto-merge December 18, 2024 11:00
@Robbert Robbert force-pushed the build/enable-tokens-studio-transform-group-voorbeeld-thema branch from 5977211 to e6e7c45 Compare December 18, 2024 11:02
@Robbert Robbert enabled auto-merge (rebase) December 18, 2024 11:03
@Robbert Robbert merged commit 5ec07da into main Dec 18, 2024
6 of 7 checks passed
@Robbert Robbert deleted the build/enable-tokens-studio-transform-group-voorbeeld-thema branch December 18, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants