Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch round 2024 05 #381

Merged
merged 3 commits into from
May 15, 2024
Merged

Patch round 2024 05 #381

merged 3 commits into from
May 15, 2024

Conversation

matijs
Copy link
Member

@matijs matijs commented May 8, 2024

  • remove unused dependencies from components-css
  • remove styleling-config-prettier, not needed since stylelint 15
  • remove @types/date-fns, built-in nowadays
  • install patch updates
  • install minor updates
  • install major updates
  • Bump Storybook to v8
  • Remove unsupported addons
  • Replace custom Prettier source solution with @whitespace/storybook-addon-html that now supports Storybook v8

matijs added 2 commits May 8, 2024 16:39
- remove unused dependencies from components-css
- remove styleling-config-prettier, not needed since stylelint 15
- remove @types/date-fns, built-in nowadays
- install patch updates
- install minor updates
- install major updates
- Bump Storybook to v8
- Remove unsupported addons
- Replace custom Prettier source solution with
  `@whitespace/storybook-addon-html` that now supports Storybook v8
@matijs matijs requested review from Robbert and bddjong May 8, 2024 18:08
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rijkshuisstijl-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 3:16pm
rvs-rivm-nl ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 3:16pm

@Robbert
Copy link
Member

Robbert commented May 10, 2024

Ik vind het een goed idee om de HTML overal toe te voegen! Hij was af en toe wat problematisch met updaten inderdaad, die heeft het niet overal gehaald.

Het is niet de bedoeling dat de "View source" knop primair voor React is, by default. NL Design System is bedoeld als project om platform-onafhankelijk toegankelijke code uit te wisselen, en daar is die HTML view source voor.

Die addon drawer is ook echt iets voor power users, veel mensen voor wie de HTML belangrijk is weten die niet te vinden

packages/storybook/config/preview.tsx Outdated Show resolved Hide resolved
@Robbert Robbert merged commit 6588dbf into main May 15, 2024
9 checks passed
@Robbert Robbert deleted the build/patch-round-2024-05 branch May 15, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants