Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image #477

Closed
AdhamAH opened this issue Jul 31, 2024 · 0 comments · Fixed by #534
Closed

Image #477

AdhamAH opened this issue Jul 31, 2024 · 0 comments · Fixed by #534
Assignees
@Rozerinay

Comments

@AdhamAH
Copy link
Member

AdhamAH commented Jul 31, 2024 •
edited by Rozerinay
Loading

Voor de NLdoc pagina is er een image nodig die keep aspect ratio doet.

Je kunt de Utrecht Image gebruiken met de photo boolean. Misschien wil je die wel standaard op true zetten?

https://nl-design-system.github.io/utrecht/storybook-react/?path=/docs/react-image--docs

<Image
  alt="Nijntje mascotte met Vuelta 2022 t-shirt bij het Utrecht stadskantoor"
  height={1536}
  photo
  src="example/photo-nijntje-vuelta.jpg"
  width={2048}
/>

Als je een Next.js image wilt hebben, met image size optimization en source sets and all the good things, die is ook al een keer gemaakt, vraag @Robbert of @AliKdhim87

Figma
Image in NLDS - Rijksoverheid - Bibliotheek
@AdhamAH AdhamAH converted this from a draft issue Jul 31, 2024
@Robbert Robbert mentioned this issue Jul 31, 2024
Closed
20 tasks
@sjimbonator sjimbonator self-assigned this Jul 31, 2024
@Rerbun Rerbun mentioned this issue Aug 14, 2024
Merged
@Rerbun Rerbun self-assigned this Aug 14, 2024
@Rerbun Rerbun closed this as completed in 70381ba Aug 15, 2024
MeesD94 added a commit that referenced this issue Aug 22, 2024
@Rerbun @MeesD94
Component/image (#534)
372bb14 
closes #477

---------

Co-authored-by: Ruben Smit <[email protected]>
Co-authored-by: Mees <[email protected]>
Co-authored-by: Sjimmie <[email protected]>
@Rozerinay Rozerinay assigned Rozerinay and unassigned Rerbun Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rozerinay Rozerinay

Labels
None yet
Projects
Community Sprint - Rijkshuisstijl componenten
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Component/image nl-design-system/rijkshuisstijl-community
4 participants
@Rerbun @sjimbonator @AdhamAH @Rozerinay