Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link #474

Closed
Robbert opened this issue Jul 31, 2024 · 2 comments · Fixed by #520 or #626
Closed

Link #474

Robbert opened this issue Jul 31, 2024 · 2 comments · Fixed by #520 or #626
Assignees
@Rerbun @AlineNap

Comments

@Robbert
Copy link
Member

Robbert commented Jul 31, 2024 •
edited by Rozerinay
Loading

Bestaat al in Storybook, kan misschien nog uitgebreid worden:
https://nl-design-system.github.io/rijkshuisstijl-community/?path=/docs/logius-link--docs

Figma
Link component in NLDS - Rijksoverheid - Bibliotheek
@Robbert Robbert converted this from a draft issue Jul 31, 2024
@Robbert Robbert moved this from Todo to In Progress in Community Sprint - Rijkshuisstijl componenten Jul 31, 2024
@Rerbun Rerbun self-assigned this Aug 7, 2024
@Rerbun Rerbun mentioned this issue Aug 7, 2024
Merged
@Rerbun Rerbun closed this as completed in 6a6c906 Aug 19, 2024
MeesD94 pushed a commit that referenced this issue Aug 22, 2024
@Rerbun
Feature/link (#520)
a3ee4dd 
Closes #474 
Closes #448

---------

Co-authored-by: Ruben Smit <[email protected]>
@Rozerinay Rozerinay assigned AlineNap and unassigned Rerbun Sep 3, 2024
@AlineNap
Copy link
Contributor

AlineNap commented Sep 5, 2024 •
edited
Loading

  1. Icon size hoort rhc.size.icon.functional groot te zijn ipv 18px: hier een PR daarvoor.
  2. Graag de active en visited state toevoegen aan de stories zodat wij als designers alle states kunnen reviewen
  3. Het icoon van de external link veranderd niet naar de hover kleur, bij de andere link iconen wel.
  4. Bij kleinere viewport wordt icon verkleint. Zie screenshot.
  5. Het icoon is gecentreerd, dat moet niet. Hij hoort linksboven uitgelijnd te worden naast de tekst. Zie screenshot.
Screenshot 2024-09-05 at 16 33 46

@AlineNap AlineNap mentioned this issue Sep 6, 2024
Closed
@Rerbun Rerbun mentioned this issue Sep 6, 2024
Merged
@AlineNap
Copy link
Contributor

AlineNap commented Sep 9, 2024

  1. Fixed in PR.
  2. ?
  3. Done in PR
  4. Feels done in bovenstaande PR.
  5. Same

AdhamAH pushed a commit that referenced this issue Sep 11, 2024
@Rerbun
feat(link): changed styling and icon after design feedback (#626)
143d39f 
closes #474 and #448

Changes are based on feedback:
#474 (comment)

---------

Co-authored-by: Ruben Smit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rerbun Rerbun

@AlineNap AlineNap

Labels
None yet
Projects
Community Sprint - Rijkshuisstijl componenten
Status: Done
Milestone
No milestone
3 participants
@Robbert @Rerbun @AlineNap