Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React components/select #329

Merged
merged 12 commits into from
Nov 27, 2024
Merged

React components/select #329

merged 12 commits into from
Nov 27, 2024

Conversation

MMeijerink
Copy link
Contributor

@MMeijerink MMeijerink commented Nov 6, 2024 •
edited by remypar5
Loading

Contents

Checklist

  • New features/components and bugfixes are covered by tests
  • Changesets are created
  • Definition of Done is checked

@MMeijerink MMeijerink linked an issue Nov 6, 2024 that may be closed by this pull request
Select #310
Closed
13 tasks
@MMeijerink MMeijerink requested a review from MrSkippy November 6, 2024 09:21
@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lux ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 2:40pm

@MMeijerink MMeijerink requested a review from remypar5 November 6, 2024 09:21
@MMeijerink MMeijerink changed the title Select Component React React components/select Nov 6, 2024
@remypar5 remypar5 self-assigned this Nov 6, 2024
remypar5
remypar5 requested changes Nov 6, 2024
View reviewed changes
packages/components-react/src/select/Select.tsx Outdated Show resolved Hide resolved
packages/storybook/src/react-components/select/select.mdx Outdated Show resolved Hide resolved
packages/components-react/src/index.ts Outdated Show resolved Hide resolved
packages/storybook/src/react-components/select/select.stories.tsx Outdated Show resolved Hide resolved
@remypar5 remypar5 self-requested a review November 6, 2024 10:59
remypar5
remypar5 previously requested changes Nov 6, 2024
View reviewed changes
packages/components-react/src/select/Select.tsx Outdated Show resolved Hide resolved
MrSkippy
MrSkippy previously approved these changes Nov 11, 2024
View reviewed changes
@MrSkippy
Copy link
Contributor

Nog even de laatste main mergen en displayName bij components.

MrSkippy
MrSkippy previously approved these changes Nov 26, 2024
View reviewed changes
@MrSkippy MrSkippy dismissed remypar5’s stale review November 26, 2024 12:10

Changes are resolved

MrSkippy
MrSkippy previously approved these changes Nov 26, 2024
View reviewed changes
@MrSkippy MrSkippy merged commit 90370e7 into main Nov 27, 2024
12 checks passed
@MrSkippy MrSkippy deleted the react-components/select branch November 27, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSkippy MrSkippy MrSkippy approved these changes

@remypar5 remypar5 Awaiting requested review from remypar5

Assignees

@remypar5 remypar5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select
3 participants
@MMeijerink @MrSkippy @remypar5