Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button #231

Closed
9 of 10 tasks
MrSkippy opened this issue Sep 19, 2024 · 0 comments · Fixed by #304
Closed
9 of 10 tasks

Button #231

MrSkippy opened this issue Sep 19, 2024 · 0 comments · Fixed by #304
Assignees
@MMeijerink
Labels
design tokens This issue needs design tokens changes new component Adding a new component to the library react Issue involving a ReactJS component

Comments

@MrSkippy
Copy link
Contributor

MrSkippy commented Sep 19, 2024 •
edited by MMeijerink
Loading

Omschrijving

Utrecht Button naar Lux Button met de volgende features:

  • positionering Icon
  • smalle variant, size property, options: alleen small op dit moment, is size niet gezet, dan is het de default size. Voeg hiervoor de lux tokens lux.button.small.* toe aan het utrecht component.

Dit is al deels gedaan tijdens de poc van de hackathon. Gebruik dit als inspiratie.

Definition of done

Component

  • Component is beschikbaar in de index
  • Design tokens worden gebruikt

Storybook

  • Playground story
  • States en properties stories
  • Korte beschrijving van het component
    • Wat doet het
    • Basis van het component (bijv Utrecht)
    • Aanpassingen en/of uitbreidingen
    • Relatie met andere componenten (bijv. Form field label en Form field)

Tests

  • Het component rendert
  • Aanpassingen en/of uitbreidingen werken
  • Visual regression test (LUX)

Links

Component: https://www.nldesignsystem.nl/button
Figma: https://www.figma.com/design/jzxqJv4PtgHJdmOJwY6lYg/NLDS---Bibliotheek---LUX-tokens?node-id=153-1138
Utrecht: https://nl-design-system.github.io/utrecht/storybook/?path=/docs/react_react-button--docs
PR met button tokens: #276
@MrSkippy MrSkippy added new component Adding a new component to the library react Issue involving a ReactJS component labels Oct 1, 2024
@AlineNap AlineNap mentioned this issue Oct 7, 2024
Merged
1 task
@MrSkippy MrSkippy added the design tokens This issue needs design tokens changes label Oct 7, 2024
AlineNap added a commit that referenced this issue Oct 7, 2024
@AlineNap
feat(design tokens): Button update: small variant + utrecht font-size…
6e97df6 
…s voor secondary en subtle (#276)

# Contents

Token update voor de button: 
- Tokens voor smalle variant 
- Line-height en font-size tokens voor secondary en subtle button
toegevoegd

Voor dit ticket: #231

## Checklist

<!-- Surround an item with double tildes `~~` to indicate that it does
not apply to this PR -->

- ~~[ ] New features/components and bugfixes are covered by tests~~
- [x] Changesets are created
- ~~[ ] Definition of Done is checked~~

---------

Co-authored-by: Jaap-Hein Wester <[email protected]>
@MMeijerink MMeijerink self-assigned this Oct 8, 2024
@MMeijerink MMeijerink linked a pull request Oct 16, 2024 that will close this issue
React components/button #304
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from In code review to Done in Lux React Components Oct 23, 2024
@MrSkippy MrSkippy mentioned this issue Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MMeijerink MMeijerink

Labels
design tokens This issue needs design tokens changes new component Adding a new component to the library react Issue involving a ReactJS component
Projects
Lux React Components
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

React components/button nl-design-system/lux
2 participants
@MrSkippy @MMeijerink