Fix focus issue in component filter, view filters when >1 filters applied #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hidde
force-pushed
the
docs/move-component-filter
branch
from
4a91fc8 to
a9c6175
Compare
focus was being reset to body, because of react router's behaviour, this no longer happens now that we use the browser's History API directly Signed-off-by: Hidde de Vries <[email protected]>
Signed-off-by: Hidde de Vries <[email protected]>
(as its logic depends on a window to exist) Signed-off-by: Hidde de Vries <[email protected]>
hidde
force-pushed
the
docs/move-component-filter
branch
from
b2de5cd to
3db9c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(don't mind the branch name, I didn't move the filter, I only removed the dependency on Docusaurus' copy of React Router for this specific feature)
Veranderingen
useHistorydie Docusaurus vanuit React Router re-export. Dit fixt gelijk ook het issue dat focus teruggaat naar de body bij change