-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip transform for vite-imagetools #68
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
in that nuxt PR, it looks like they also a vite plugin that handles the skip_transform part. do we not need that as well? who receives this skip transform thing and what do they do with it? |
Yeah I thought i would have to add more like that pr but this seems to fix it. Not sure if "_skip_transform" is a special property vite looks for maybe? |
Yeah I don't think this is quite right... it fixes it but no idea why. I can name the property anything |
I looked for it in the vite repo and there was nothing there |
And the nuxt fix is for this similar issue or something else? |
I explored this more and found other things that cumulatively will solve this issue: #72 In terms of usage, we will have to use the function form of the plugins options: import { defineConfig } from "@solidjs/start/config";
import { imagetools } from "vite-imagetools";
export default defineConfig({
plugins: () => [imagetools({})],
}); |
It seems to fix this specific issue. I'm just not 100% sure if it has any negative effects.
Seems to fix this issue: solidjs/solid-start#1195
Fix based on this pr: https://github.com/nuxt/framework/pull/9602/files
Before:
After: