Skip to content

Commit

Permalink
roachprod: dismiss signup banner for nodes started by roachprod
Browse files Browse the repository at this point in the history
Previously, when starting a node using roachprod, the db console
ui would display a release notes signup banner. This banner is not
useful for users of roachprod. We introduced a way to toggle this
via env var in cockroachdb#56437. This commit sets that
env var, COCKROACH_UI_RELEASE_NOTES_SIGNUP_DISMISSED=true for
`cockroach start*` commands issued from roachprod.

Resolves: cockroachdb#46998
See also: cockroachdb#56437

Release note: none
  • Loading branch information
nkodali committed Nov 12, 2020
1 parent 6de9bf8 commit b9af963
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/cmd/roachprod/install/cockroach.go
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ func (h *crdbInstallHelper) generateStartCmd(
[ -x /usr/bin/lslocks ] && /usr/bin/lslocks >> %[1]s/roachprod.log; %[2]s
export ROACHPROD=%[3]d%[4]s;
GOTRACEBACK=crash COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING=1 %[5]s \
COCKROACH_UI_RELEASE_NOTES_SIGNUP_DISMISSED=true \
%[6]s %[7]s %[8]s >> %[1]s/cockroach.stdout.log \
2>> %[1]s/cockroach.stderr.log \
|| (x=$?; cat %[1]s/cockroach.stderr.log; exit $x)`,
Expand Down

0 comments on commit b9af963

Please sign in to comment.