-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance update #27
Conversation
According to the instructions, npm is used.
Thanks @KristjanESPERANTO for this PR and your work! There are many and I don't think it's necessary to change all these formatting aspects. Could you try to find a Prettier configuration that doesn't result in so many changes? E.g. trailing comma in objets/arrays should be mandatory. There should be no whitespace after the |
I know it's a bit difficult to keep track of the changes when there are so many in one PR. Sorry for that. |
I read about Prettier and found out that it is "opinionated" with very few options. I think that's reasonable as "the biggest reason for adopting Prettier is to stop all the on-going debates over styles". Sounds good. I'd like to honor your work and therefore stop the discussion about whitespaces and blank lines to accept this PR, but there are two more things that are important for me:
Thanks again for your work! In the last years I was busy with other things, but maybe I should also spend some time to improve this module, as it seems to be useful for some people :) |
|
Tested on my mirror and works like a charm! Thank you very much @KristjanESPERANTO 👏 |
You're welcome! BTW, MMM-OnThisDay is now displayed very well on the module page that I am building. |
The PR does not contain any functional updates. Roughly summarized, these are updates, typos and format harmonization.
See the commits for details.
Thanks for this nice module! 🙂