Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow adding onBlur and onKeyPress to element without force notify #73

Merged
merged 4 commits into from
Aug 2, 2017

Conversation

Data-Meister
Copy link
Contributor

Currently it is ignoring onBlur and onKeyPress handlers unless you have forceNotifyOnBlur or forceNotifyByEnter set, respectively

…orce notify

Currently it is ignoring onBlur and onKeyPress handlers unless you have forceNotifyOnBlur or forceNotifyByEnter set, respectively
Copy link
Owner

@nkbt nkbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That is definitely an oversight. Though there are some issues with formatting. And you cannot define cons eithin if/elseif/else this way either.

Will merge after fix for sure!

@nkbt
Copy link
Owner

nkbt commented Jun 29, 2017

I think my ci config is broken so it does not fail. Please run linter manually if you eish to see errors...

@Data-Meister
Copy link
Contributor Author

OK, have updated the code.

@nkbt
Copy link
Owner

nkbt commented Jul 1, 2017

Still heaps :(

Might not be yours tho. I'll check when I'm on my laptop...

> [email protected] start /home/ubuntu/react-debounce-input
> react-component-template "ci.lint"

nps executing: eslint /home/ubuntu/react-debounce-input

/home/ubuntu/react-debounce-input/src/Component.js
  153:1   error  Trailing spaces not allowed                                                   no-trailing-spaces
  154:28  error  Missing space before opening brace                                            space-before-blocks
  165:8   error  Missing semicolon                                                             semi
  166:5   error  Closing curly brace does not appear on the same line as the subsequent block  brace-style
  167:24  error  Missing space before opening brace                                            space-before-blocks
  168:35  error  Missing semicolon                                                             semi
  169:5   error  Closing curly brace does not appear on the same line as the subsequent block  brace-style
  171:26  error  Missing semicolon                                                             semi
  174:1   error  Trailing spaces not allowed                                                   no-trailing-spaces
  176:1   error  Trailing spaces not allowed                                                   no-trailing-spaces
  177:27  error  Missing space before opening brace                                            space-before-blocks
  186:8   error  Missing semicolon                                                             semi
  187:5   error  Closing curly brace does not appear on the same line as the subsequent block  brace-style
  188:21  error  Missing space before opening brace                                            space-before-blocks
  189:29  error  Missing semicolon                                                             semi
  190:5   error  Closing curly brace does not appear on the same line as the subsequent block  brace-style
  192:23  error  Missing semicolon                                                             semi

/home/ubuntu/react-debounce-input/src/example/App/UndoRedo.js
  31:25  error  Unexpected parentheses around single function argument  arrow-parens

✖ 18 problems (18 errors, 0 warnings)

@Data-Meister
Copy link
Contributor Author

Have submitted another commit. It was Previously calling .cancel() and .flush() on this.notify. Now it's calling those methods on debouncedChangeFunc - so it should fix issue #64

@Data-Meister
Copy link
Contributor Author

Hi there, I notice you've approved this PR, but I don't think it's been merged yet. Are you happy to merge it?

@nkbt
Copy link
Owner

nkbt commented Aug 2, 2017

Yeah, as soon as lint errors are fixed =)

/home/ubuntu/react-debounce-input/src/Component.js
   86:21  error  Missing space before =>                                                       arrow-spacing
   90:22  error  Missing space before =>                                                       arrow-spacing
  162:28  error  Missing space before opening brace                                            space-before-blocks
  173:8   error  Missing semicolon                                                             semi
  174:5   error  Closing curly brace does not appear on the same line as the subsequent block  brace-style
  175:24  error  Missing space before opening brace                                            space-before-blocks
  176:35  error  Missing semicolon                                                             semi
  177:5   error  Closing curly brace does not appear on the same line as the subsequent block  brace-style
  179:26  error  Missing semicolon                                                             semi
  185:27  error  Missing space before opening brace                                            space-before-blocks
  194:8   error  Missing semicolon                                                             semi
  195:5   error  Closing curly brace does not appear on the same line as the subsequent block  brace-style
  196:21  error  Missing space before opening brace                                            space-before-blocks
  197:29  error  Missing semicolon                                                             semi
  198:5   error  Closing curly brace does not appear on the same line as the subsequent block  brace-style
  200:23  error  Missing semicolon                                                             semi

/home/ubuntu/react-debounce-input/src/example/App/UndoRedo.js
  31:25  error  Unexpected parentheses around single function argument  arrow-parens

✖ 17 problems (17 errors, 0 warnings)

The problem is that p-s ignores errors and exits with code 0, this is why CI is always happy =(

I need to update the build here to get rid of this annoying issue

@Data-Meister
Copy link
Contributor Author

Have done :)

@nkbt nkbt merged commit 2c87cdd into nkbt:master Aug 2, 2017
@nkbt
Copy link
Owner

nkbt commented Aug 3, 2017

Published + [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants