-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow adding onBlur and onKeyPress to element without force notify #73
Conversation
…orce notify Currently it is ignoring onBlur and onKeyPress handlers unless you have forceNotifyOnBlur or forceNotifyByEnter set, respectively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That is definitely an oversight. Though there are some issues with formatting. And you cannot define cons eithin if/elseif/else this way either.
Will merge after fix for sure!
I think my ci config is broken so it does not fail. Please run linter manually if you eish to see errors... |
OK, have updated the code. |
Still heaps :( Might not be yours tho. I'll check when I'm on my laptop...
|
Have submitted another commit. It was Previously calling |
Hi there, I notice you've approved this PR, but I don't think it's been merged yet. Are you happy to merge it? |
Yeah, as soon as lint errors are fixed =)
The problem is that I need to update the build here to get rid of this annoying issue |
Have done :) |
Published + [email protected] |
Currently it is ignoring onBlur and onKeyPress handlers unless you have forceNotifyOnBlur or forceNotifyByEnter set, respectively