Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-codemod for componentWillMount #113

Closed
wants to merge 1 commit into from
Closed

react-codemod for componentWillMount #113

wants to merge 1 commit into from

Conversation

burrelle
Copy link

@burrelle burrelle commented Oct 1, 2019

  • Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

nkbt
nkbt reviewed Oct 1, 2019
View reviewed changes
Copy link
Owner

@nkbt nkbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I would rather prefer to fix it properly. There might even be another pr waiting. I’ll have alook at this soon (hopefully)

@nkbt nkbt self-assigned this Oct 16, 2019
@nkbt nkbt mentioned this pull request Oct 17, 2019
Merged
2 tasks
@nkbt nkbt closed this in #115 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkbt nkbt nkbt left review comments

Assignees

@nkbt nkbt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrelle @nkbt