Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds type for placeholder input #103

Merged
merged 1 commit into from Mar 27, 2018
Merged

Adds type for placeholder input #103

merged 1 commit into from Mar 27, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 27, 2018

This PR adds a type for placeholder input.

When converting a project to Typescript I was getting this Typescript compile error:

Property 'placeholder' does not exist on type 'IntrinsicAttributes & 
IntrinsicClassAttributes<Component<ThemedOuterStyledProps<WithOptionalTheme...'.

In order to resolve I added a type for placeholder in index.d.ts. I thought others using Typescript might benefit from this change so am opening a PR for your consideration.

@nkbt nkbt merged commit adf1b5a into nkbt:master Mar 27, 2018
@jariz
Copy link

jariz commented May 14, 2019

hey @nkbt, any chance this can get released on npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants