Fixes enum issue when defined outside a message. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atgjack thanks for making this PR! |
|
can someone merge this request? @njpatel |
|
Sorry for the delay on this, grpc v1.1.2 is being published to npm now with this fix. Thanks for the contribution @atgjack ! |
|
Thanks @njpatel! This project is awesome 💖 |
Still happens in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix an issue where Enumerations that are defined outside of a message body throwing an error. I saw that there was a test that checks it, and it passes. However, when I call the following code from the CLI:
node bin/grpcc.js -p test/test.proto - a localhost:8080I receive the following error:
Unable to find any service in proto fileThere is currently an open issue(#46) about this.
The issue seems to stem from a shadowed variable, so it's a simple fix. I'd be interested to know why the test passes, but when I try calling it manually it fails. Any ideas?