-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/brainy #10
Feature/brainy #10
Conversation
What a pain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I forgot why we wanted to take out dimwits. Can you enlighten me?
url = https://github.com/njoy/json-adapter.git | ||
[submodule "dependencies/hana-adapter"] | ||
path = dependencies/hana-adapter | ||
url = https://github.com/njoy/hana-adapter.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was hana added as a dependency?
I didn't see any hana code used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can’t remember why I added that. I’ll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hana is used in PLOTR. We used to get it implicitly from dimwits, but now that is removed I had to add it.
Now, maybe we could get rid of hana, but we need it for now.
There are a few reasons to remove dimwits:
|
Here we are doing the opposite of "dimwits"—being "brainy". I'm removing the units and thus dimwits from the code/repository.