Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/brainy #10

Merged
merged 10 commits into from
Dec 5, 2019
Merged

Feature/brainy #10

merged 10 commits into from
Dec 5, 2019

Conversation

jlconlin
Copy link
Member

@jlconlin jlconlin commented Nov 7, 2019

Here we are doing the opposite of "dimwits"—being "brainy". I'm removing the units and thus dimwits from the code/repository.

@jlconlin jlconlin requested a review from whaeck November 7, 2019 11:10
@jlconlin jlconlin mentioned this pull request Nov 20, 2019
Copy link
Member

@whaeck whaeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I forgot why we wanted to take out dimwits. Can you enlighten me?

url = https://github.com/njoy/json-adapter.git
[submodule "dependencies/hana-adapter"]
path = dependencies/hana-adapter
url = https://github.com/njoy/hana-adapter.git
Copy link
Member

@whaeck whaeck Nov 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was hana added as a dependency?

I didn't see any hana code used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can’t remember why I added that. I’ll remove it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hana is used in PLOTR. We used to get it implicitly from dimwits, but now that is removed I had to add it.

Now, maybe we could get rid of hana, but we need it for now.

@jlconlin
Copy link
Member Author

There are a few reasons to remove dimwits:

  • Like with several of our other libraries (ENDFtk), we are simply returning what is given on the file. There are implied units, but nothing explicit.
  • It greatly simplifies exposing this to external modules. Keeping the units makes it much harder to serialize to JSON allowing other modules to get the input parameters. Also exposing these things to Python would be challenging if we still had dimwits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants