Fix/mf35 sequence #287
Merged
Fix/mf35 sequence #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathangibson14
previously approved these changes
Feb 27, 2023
ReleaseNotes.md
Outdated
| @@ -4,6 +4,7 @@ Given here are some release notes for NJOY2016. Each release is made through a f | |||
| ## [NJOY2016.70](https://github.com/njoy/NJOY2016/pull/xxx) | |||
| This update fixes a number of minor issues: | |||
| - Fixed an issue in HEATR when reading evaluations with large multiplicity tables in MF6. | |||
| - Multiple ERRORR calls can now be made in the same input file without crashing. This is of interest to users that wish to process MF34 and MF35 (where ERRORR needs to be called for each sub-subsection and incident energy group). | |||
There was a problem hiding this comment.
You should make reference to this affecting files with LRF7 resonances without MF32 data.
|
@nathangibson14 need you to reapprove |
|
@nathangibson14 You may want to reapprove this one |
nathangibson14
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly deallocating sammy arrays solves the issue when running multiple ERRORR isntances in the same input.