Fix/tendl d+pt184 #224
Merged
Fix/tendl d+pt184 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathangibson14
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Very simple fix! Looks good to me.
My only concern is we should be a bit careful with the test cases of putting in too many ENDF files. We don't want downloads of NJOY to get out of hand, particularly with all the history tracked in Git. This one isn't terribly big, so I'm not worried, but something to be wary of going forward.
|
Good point, but our biggest concern should actually be the reference files we use in the tests. The current size of the tests folder is 539 MB while the resources folder is only 148 MB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small update to include MT11 as a deuteron producing reaction, following issue #223 and #184
Since this is needed for processing TENDL-2021, we're doing a small release (NJOY2016.65).