forked from AliceO2Group/AliceO2
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
final tof params object #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* increase factorize lanes to 10 * Increase number of Buffer to 100
This should be useful when a object (digit) has no associated label. https://alice.its.cern.ch/jira/browse/O2-3352
… noisy pad filter.
Spotted by some syntetic run. The copy was taking 10% of the CPU utilization.
And per default make the container type the same as the input type. Useful in case the object send to the aggregator is in itself already a container as for example a histogram.
…during device compilation" This reverts commit 73c10d5.
* ITS DCS parser: add always run number to metadata * clang
Mapping pad channel to position on pad layer
The TriggerOffsetsParam configurableParam got array of custom corrections per detector (0 by default) which can be applied to triggered detectors IR as an ADDITIVE correction during CTF decoding. Note that this convention is opposite to that for the LM_L0 convention which is subtracted from the encoded IR (at the moment only for the TRD if an option --correct-trd-trigger-offset was provided to the ctf-reader). Therefore, for the TRD, if this option is ON, the effect of the correction is ir_corrected = ir_decoded - TriggerOffsetsParam::LM_L0 + TriggerOffsetsParam::customOffset[TRD]; while for other EMC,PHS,CPV and HMP (and TRD in absence of --correct-trd-trigger-offset) it is simply ir_corrected = ir_decoded + TriggerOffsetsParam::customOffset[<det>]; In case the correction moves the IR before the TF 1st orbit, the trigger is discarded. Extra: ZDC in pbpb2022 was reseting the orbit internally to 1 at the SOR: implemented the shift also for it.
- Calibrated time and calibrated energy were switched which results in wrong values energy and time in the AO2D file
This patch allows outputting the full vdrift exb calibration to a file. Additionally, it adds a previously missed function call to update the configKeyValues from cli args. Signed-off-by: Felix Schlepper <[email protected]>
These special triggers can be shifted only orbit-wise but the BC must remain unchanged
Compare data-members explicitly to avoid padding problems in blockwise comparison
* HepMC and Gen status codes handled/entangled via Union as one single integer * some common functionality to en-/decode * encoding fully implemented for Pythia8, O2Kine and HepMC generators * be backwards-compatible wrt to HepMC status code * O2Kine generator now sets the status code correctly * use ParticleStatus::kToBeDone for TParticle in generators at Generator::importParticles to indicate whether to-be-done or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.