Use Wrapping for intended underflow of unsigned integer value. #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,11 +111,15 @@ pub fn chdir<P: ?Sized + NixPath>(path: &P) -> Result<()> { | |||
| Errno::result(res).map(drop) | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Any reason for adding these 2 lines?
|
I readded the (reworded) comment. |
| use std::num::Wrapping; | ||
| unsafe { libc::chown(cstr.as_ptr(), | ||
| owner.unwrap_or((Wrapping(0 as uid_t) - Wrapping(1 as uid_t)).0), | ||
| group.unwrap_or((Wrapping(0 as gid_t) - Wrapping(1 as gid_t)).0)) } |
There was a problem hiding this comment.
one last nit, can we use 0.wrapping_sub(1) instead of using Wrapping? I think it'll be easier to read and doesn't require an extra import.
There was a problem hiding this comment.
Certainly! If I had known the function, I would have used it right away.
homu
added a commit
that referenced
this pull request
May 6, 2016
Use Wrapping for intended underflow of unsigned integer value. This fixes an warning made error on nightly builds.
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an warning made error on nightly builds.