Fixed warning with raw_pointer_derive #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI result shows you why we cannot just remove it. We currently support older versions of rust, where the error was still a thing. |
|
I had a plan for this, but I forgot what it was! |
kamalmarhubi
added a commit
to kamalmarhubi/nix-rust
that referenced
this pull request
Apr 1, 2016
This commit adds a small build script to detect if we need to `#[allow(raw_pointer_derive)]` and makes the attribute conditional. Refs nix-rust#337
kamalmarhubi
added a commit
to kamalmarhubi/nix-rust
that referenced
this pull request
Apr 2, 2016
This commit adds a small build script to detect if we need to `#[allow(raw_pointer_derive)]` and makes the attribute conditional. Refs nix-rust#337
homu
added a commit
that referenced
this pull request
Apr 2, 2016
…=posborne Fix raw_pointer_derive warning This commit adds a small build script to detect if we need to `#[allow(raw_pointer_derive)]` and makes the attribute conditional. Refs #337
|
☔ The latest upstream changes (presumably #340) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to allow raw_pointer_derive, and it gives a warning in Rust stable. This fixes that warning.