fcntls fix build for solaris. #2542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
reviewed
Nov 19, 2024
| @@ -141,7 +141,7 @@ libc_bitflags!( | |||
| #[cfg(any( | |||
| freebsdlike, | |||
| linux_android, | |||
| solarish, | |||
| target_os = "illumos", | |||
There was a problem hiding this comment.
According to the error log, this O_DIRECT thing is not the only missing symbol, it also needs SIGINFO.
Are these symbols not available on the target?
|
I think #2544 is a better solution for the issue, which covers all the Solaris build problems and adds the CI, so I am going to close this PR, sorry. 😶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2540