chore: ignore lint unsafe_op_in_unsafe_fn for usage of env::remove_var #2421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
std::env::remove_var
has been made unsafe. Due to lintunsafe_op_in_unsafe_fn
, we need to wrap it in an unsafe block.This PR is for the following CI failure (full log here):
std::env::remove_var()
will become unsafe ONLY in Rust 2024, Nix is using Rust 2021, so the above issue should not happen. I have filed an issue for this bug, before it gets fixed, ignore the lintunsafe_op_in_unsafe_fn
here.Checklist:
CONTRIBUTING.md