Add fanotify API wrappers #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad0
force-pushed
the
fanotify
branch
2 times, most recently
from
c3c044d
to
63acd98
Compare
SteveLauC
requested changes
Nov 19, 2023
|
Hi, thanks for your interest in contributing to Nix, I have left some comments on this PR:) |
|
Hi, thank you for the detailled review, I'll treat your comments asap! |
SteveLauC
requested changes
Nov 20, 2023
ad0
force-pushed
the
fanotify
branch
3 times, most recently
from
8d6d0d2
to
63c2620
Compare
SteveLauC
requested changes
Nov 20, 2023
|
Let's merge this PR, mind removing the WIP/Draft status? |
SteveLauC
approved these changes
Nov 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
That tier3 (armv7-unknown-linux-uclibceabihf) CI failure is probably a nightly Rust bug, see also this comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
It adds linux fanotify API support: wrappers for libc
fanotify_initandfanotify_markfunctions.Note that it requires libc version 0.2.150 since it introduces necessary fanotify constants (rust-lang/libc#3408).
Checklist:
CONTRIBUTING.md