Fix #1093 #1121
Merged
Fix #1093 #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tathanhdinh
force-pushed
the
replace_cstring
branch
2 times, most recently
from
27ad2c0 to
21ed20a
Compare
asomers
requested changes
Sep 12, 2019
tathanhdinh
force-pushed
the
replace_cstring
branch
from
21ed20a to
d08fe65
Compare
|
Thank you for the feedback. CHANGELOG modified. |
asomers
approved these changes
Sep 16, 2019
|
Looks good now. As soon as PR #1123 is done, you'll be able to rebase this one and the test failures will be fixed. |
|
Thank you. I'm waiting for PR #1123 now. |
|
You should be able to rebase now. |
tathanhdinh
force-pushed
the
replace_cstring
branch
from
d08fe65 to
9ebc633
Compare
|
Thank you. The PR is rebased. |
|
@tathanhdinh the commit log could receive some love, don't you think? I know the issue is detailed but it'd be good if the commit log could be extended with it. |
bors bot
added a commit
that referenced
this pull request
Sep 28, 2019
1121: Fix #1093 r=asomers a=tathanhdinh Hello, This PR fixes the problem discovered in #1093. Thanks for any comment. 1130: unistd: getgrouplist: Rework code to use `reserve_double_buffer_size` r=asomers a=otavio The buffer resize logic can be simplified reusing the `reserve_double_buffer_size` method. Signed-off-by: Otavio Salvador <[email protected]> Co-authored-by: Ta Thanh Dinh <[email protected]> Co-authored-by: Otavio Salvador <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR fixes the problem discovered in #1093.
Thanks for any comment.