Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sync / syncfs #959

Closed
r-darwish opened this issue Nov 1, 2018 · 4 comments
Closed

Add sync / syncfs #959

r-darwish opened this issue Nov 1, 2018 · 4 comments

Comments

@r-darwish
Copy link
Contributor

No description provided.

@asomers
Copy link
Member

asomers commented Nov 1, 2018

Sure. Would you mind opening a PR for that?

@r-darwish
Copy link
Contributor Author

r-darwish commented Nov 1, 2018 via email

@r-darwish
Copy link
Contributor Author

It seems that syncfs is Linux specific, and isn't available in libc, so I opened a pull request containing only sync.

bors bot added a commit that referenced this issue Nov 2, 2018
@bors @r-darwish
Merge #961
5fbdb8a 
961: Add sync (fix #959) r=asomers a=r-darwish



Co-authored-by: Roey Darwish Dror <[email protected]>
@asomers
Copy link
Member

asomers commented Nov 18, 2018

Closing this completed issue. In the future, if you put "fixes # " on its own line in the commit message, then Github will automatically close the issue once the PR is merged.

@asomers asomers closed this as completed Nov 18, 2018
levex pushed a commit to levex/nix that referenced this issue Dec 3, 2018
@r-darwish @levex
Add sync (fix nix-rust#959)
389580f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asomers @r-darwish