Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New maintainers can't approve PRs #580

Closed
kamalmarhubi opened this issue Apr 15, 2017 · 3 comments
Closed

New maintainers can't approve PRs #580

kamalmarhubi opened this issue Apr 15, 2017 · 3 comments
Assignees
@kamalmarhubi

Comments

@kamalmarhubi
Copy link
Member

Noted by @Susurrus.

I'm considering attempting to move us to bors-ng which has some additional features on top of bors / homu:

  • it's actively maintained
  • it can batch PRs to merge multiple with one CI run
@kamalmarhubi kamalmarhubi self-assigned this Apr 15, 2017
@kamalmarhubi kamalmarhubi mentioned this issue Apr 15, 2017
Merged
@kamalmarhubi
Copy link
Member Author

kamalmarhubi commented Apr 15, 2017 •
edited
Loading

@Susurrus

@kamalmarhubi There's a synchronize button on the homu website and it asked for permissions to my account and nix-rust on GitHub. Do I need to do that so that I recognizes me or something?

Maybe! Give it a shot, unless the permissions are not to your liking. :-)

kamalmarhubi added a commit to kamalmarhubi/nix-rust that referenced this issue Apr 15, 2017
@kamalmarhubi
Replace homu with bors-ng
99d14d9 
@homu has served us well, but is unmaintained. @bors will serve us in
its stead.

Fixes nix-rust#580
@kamalmarhubi kamalmarhubi mentioned this issue Apr 15, 2017
Merged
kamalmarhubi added a commit to kamalmarhubi/nix-rust that referenced this issue Apr 15, 2017
@kamalmarhubi
Replace homu with bors-ng
457b6ae 
@homu has served us well, but is unmaintained. @bors will serve us in
its stead.

Fixes nix-rust#580
kamalmarhubi added a commit to kamalmarhubi/nix-rust that referenced this issue Apr 15, 2017
@kamalmarhubi
Replace homu with bors-ng
11c17cc 
@homu has served us well, but is unmaintained. bors will serve us in
its stead.

Fixes nix-rust#580
bors bot added a commit that referenced this issue Apr 16, 2017
@bors
Merge #584
6a05ee0 
584: Replace homu with bors-ng r=posborne
@homu has served us well, but is unmaintained. @bors will serve us in
its stead.

Fixes #580
@posborne
Copy link
Member

👍 on moving to Bors!

@bors bors bot closed this as completed in #584 Apr 16, 2017
@kamalmarhubi
Copy link
Member Author

kamalmarhubi commented Apr 16, 2017 •
edited
Loading

@nix-rust/nix-maintainers FYI @homu is no more. The new way to approve PRs is bors r+, or bors r=username (note: no @ in those commands).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamalmarhubi kamalmarhubi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@posborne @kamalmarhubi