log-id not passed to post-build-hook #19
Comments
raboof
added a commit
to raboof/trustix
that referenced
this issue
Jun 21, 2021
It seems the post-build-hook configuration option, at least on my nix version (2.3.12), accepts only the path to an executable, not a complete command line. Without this change I got: ``` post-build-hook: error: executing '/nix/store/g48w1vfxbl1p7rbsmd1y999g45c61r7z-trustix-dev/bin/trustix-nix post-build-hook --address /run/trustix-daemon.socket': No such file or directory ``` (even with this change it doesn't work yet because the address path needs a `unix://` prefix to make the dialer accept it, and there's nix-community#19 and nix-community#20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I configure a publisher using the module, it automatically registers the post-build-hook, calling
trustix-nixwithout alog-idparameter:https://github.com/tweag/trustix/blob/9bf6f32ab9b28c49fdc12c6e7a847a2b6dc1aa00/packages/trustix-nix/nixos/post-build-hook.nix#L32
However, this parameter is mandatory:
https://github.com/tweag/trustix/blob/9bf6f32ab9b28c49fdc12c6e7a847a2b6dc1aa00/packages/trustix-nix/cmd/post-build-hook.go#L33-L35
It seems the LogID can be derived from the key type and public key, which are also present in the publisher config. Perhaps post-build-hook.nix should by default get those two fields from the publisher config, and pass them to post-build-hook.go so it can derive the LogID from them? Or am I misunderstanding how this is meant to hang together?
The text was updated successfully, but these errors were encountered: