Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highlighting in string escapes for emacs tree-sitter-mode #38

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jun 2, 2023

Reason

tree-sitter-mode seems a bit picky about the order in which expressions are listed in highlights.scm and won't highlight expressions inside string escapes correctly without this change. Note: I haven't tried the change with any other editor.

Before and after

before
after

@adisbladis adisbladis force-pushed the master branch 2 times, most recently from d1df27d to 43471e6 Compare July 7, 2023 12:51
tree-sitter-mode seems a bit picky about the order in which
expressions are listed in highlights.scm and won't highlight
expressions inside string escapes correctly without this change.
@adisbladis
Copy link
Member

@cstrahan Since you're not super active in maintaining this repo would you mind if I merged this PR, and possibly others in the future too?

@adisbladis
Copy link
Member

I plan to merge this in a few days unless I get feedback from @cstrahan to the contrary.

@adisbladis adisbladis mentioned this pull request Dec 22, 2023
@adisbladis adisbladis merged commit 763168f into nix-community:master Dec 26, 2023
9 checks passed
@cstrahan
Copy link
Collaborator

@adisbladis You have my blessing to merge whatever you wish going forward 👍. I've been oversubscribed for a little too long now, and getting hit with a second layoff (just a year after my first) doesn't help. Whenever things chill out in my life I'd love to be more active here and in other corners of the Nix ecosystem, but I dunno when that'll be...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants