Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overrides: Disable fortify during build of msgspec to avoid SIGABRT during JSON generation #1784

Merged
merged 1 commit into from
Sep 2, 2024
Merged

overrides: Disable fortify during build of msgspec to avoid SIGABRT during JSON generation #1784

merged 1 commit into from
Sep 2, 2024

Conversation

charles-dyfis-net
Copy link
Contributor

Contribution checklist (recommended but not always applicable/required):

  • There's an automated test for this change
  • Commit messages or code include references to related issues or PRs (including third parties)
  • Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"

@charles-dyfis-net
Copy link
Contributor Author

We could also avoid this issue by setting CFLAGS="-O2" without disabling fortify, but I'm calling this the more parsimonious change.

@adisbladis adisbladis enabled auto-merge (rebase) September 2, 2024 05:11
@adisbladis adisbladis merged commit 0d3fad5 into nix-community:master Sep 2, 2024
179 checks passed
@bclaud bclaud mentioned this pull request Sep 2, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charles-dyfis-net @adisbladis