Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add docs/footguns.md #1315

Merged
merged 2 commits into from
Oct 28, 2023
Merged

docs: add docs/footguns.md #1315

merged 2 commits into from
Oct 28, 2023

Conversation

fzakaria
Copy link
Contributor

Add a new doc explaining the footgun that can happen if you chose to override the package version for a python package in poetry2nix

fixes #1314

l0b0
l0b0 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@l0b0 l0b0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not sure if this should be in its own file, though, since it makes it much harder to discover than something in the readme.

@fzakaria @cpcloud
docs: add docs/footguns.md
d5c5384 
Add a new doc explaining the footgun that can happen if you chose to
override the package version for a python package in poetry2nix

fixes nix-community#1314
@cpcloud
Copy link
Collaborator

cpcloud commented Oct 28, 2023

I moved this into edgecases.md and removed the editorializing.

@cpcloud cpcloud merged commit d1e04ed into nix-community:master Oct 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0b0 l0b0 l0b0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Surprising versions selected if overrides are used.
3 participants
@fzakaria @cpcloud @l0b0