Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-systems.json for sphinxcontrib-jquery #1248

Merged
merged 2 commits into from
Aug 5, 2023

Conversation

brendon-boldt
Copy link
Contributor

First time contributor to this repo. I am not sure of what the best method for testing this update is in situ. I found that this override fixed an issue with building sphinx-rtd-theme with poetry2nix (i.e., sphinxcontriib-jquery not being able to find flit_core).

@adisbladis
Copy link
Member

This looks good except the build systems need to be sorted. You can use jq --sort-keys.

@brendon-boldt
Copy link
Contributor Author

Duh, I knew that and did it by hand but didn't go through the trouble of noting that "q" goes before "s". 🤦 Thanks for your patience...

@adisbladis adisbladis added this pull request to the merge queue Aug 5, 2023
Merged via the queue into nix-community:master with commit d637c4a Aug 5, 2023
108 checks passed
@brendon-boldt brendon-boldt deleted the patch-1 branch August 7, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants