feat(input): touchpad.scrollSpeed #443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aster-void
force-pushed
the
touchpad-scroll-speed
branch
from
2782311 to
fe1a196
Compare
aster-void
force-pushed
the
touchpad-scroll-speed
branch
from
fe1a196 to
a3aa2bc
Compare
aster-void
changed the title
bew
reviewed
Dec 24, 2024
| @@ -222,6 +231,7 @@ let | |||
| TapAndDrag = touchpad.tapAndDrag; | |||
| TapDragLock = touchpad.tapDragLock; | |||
| ScrollMethod = touchpad.scrollMethod; | |||
| ScrollFactor = touchpad.scrollSpeed; | |||
There was a problem hiding this comment.
Why not call it scrollFactor like the actual config option?
There was a problem hiding this comment.
because it's also called scrollSpeed in mouse section.
I followed it because scrollFactor is a little bit unintuitive and would make it difficult to search and autocomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.