-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Additions to PowerDevil Configuration #379
Various Additions to PowerDevil Configuration #379
Conversation
…istency with other options
…d - which seems to be the plasma 6 behaviour
Didn't test it yet, but I just noticed there some 4 spaces indent in the file. Could you please format it with |
Not sure why that closed, but that should be formatted properly now |
it will be a simple change, so it doesn't really need backwards compatibility. Since nix will already tell the fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Did some minor changes to ensure consistency. But I'll let @magnouvean merge this. Since I don't really have a laptop, so I can't test some of these options
I'll try to test it this weekend. Sorry for the longer delays here recently, I've been really busy with work lately. |
Mostly looks very good from my testing, but with the displayBrightness I see that when this option is set the "change screen brightness" toggle is still disabled by default. In my opinion this should automatically be enabled when this value is set, since the changing of the display brightness won't have any effect until this toggle is turned on. This should be as simple as setting:
in the powerdevilrc. Alternatively it could be added as a separate option if you think it makes sense to configure these two options independently of each other (I'd be fine with either solution tbh). Once this is fixed I think everything is good. |
I just opened a PR with changes to powerdevil, changes I had been working on for several days. I hadn't seen that this PR was open. I swear it was not an attempt to compete, I opened it from the fork on my profile, without looking at the project's PR list. |
That's fine, your pr seems more general while this is a little more specific, so I think we can merge this first when things are fixed and then resolve conflicts and test/merge yours @tucho :) |
Nice! Thank you @magnouvean for your reply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks very good from my testing, but with the displayBrightness I see that when this option is set the "change screen brightness" toggle is still disabled by default. In my opinion this should automatically be enabled when this value is set, since the changing of the display brightness won't have any effect until this toggle is turned on. This should be as simple as setting:
UseProfileSpecificDisplayBrightness=true
in the powerdevilrc. Alternatively it could be added as a separate option if you think it makes sense to configure these two options independently of each other (I'd be fine with either solution tbh). Once this is fixed I think everything is good.
Thank you, I must have missed that when I was developing this, as mine would have been set previously. My config is also partially ported from Plasma 5, so some of the values are still in the old file location, and I will have missed this when I checked that everything in my PowerDevilrc was available as an option.
It works fine now. I'll merge right away, thanks for the contribution :) |
This PR includes various additions to the plasma-manager powerdevil module - for configuring the KDE Plasma Power Management Settings:
There are also a couple of bugfixes: