modules/files: fix creating configs of vim type #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
requested changes
Jul 19, 2024
| plugin = helpers.writeLua derivationName config.content; | ||
| plugin = | ||
| let | ||
| writeContent = if config.type == "lua" then helpers.writeLua else pkgs.writeText; |
There was a problem hiding this comment.
I think it's more readable with this in the same let block as derivationName.
Also: in #1889 I named the function writer, although that's not really important. writeContent is fine, just a little verbose.
There was a problem hiding this comment.
Maybe I'm wrong, but isn't a verb better in that case? I named it by analogy to writeLua and writeText.
|
Also, could you rebase on |
|
Update: |
MattSturgeon
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix extracted from #1886. Since #1889 also fixes that, maybe this PR is redundant. But at least tests are fixed here (I think that
files.nixwas placed in the wrong directory, because I didn't find any reference to it). Also added a test case for the error this is fixing. Feel free to close if #1889 is merged earlier.