Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins/lsp/nil-ls: refactor options #1614

Merged
merged 1 commit into from
Jun 2, 2024
Merged

plugins/lsp/nil-ls: refactor options #1614

merged 1 commit into from
Jun 2, 2024

Conversation

GaetanLepage
Copy link
Member

No description provided.

@GaetanLepage GaetanLepage requested a review from a team June 1, 2024 14:01
MattSturgeon

This comment was marked as resolved.

Sign in to view

@MattSturgeon MattSturgeon mentioned this pull request Jun 2, 2024
Merged
@MattSturgeon
Copy link
Member

@GaetanLepage hope you don't mind, I force-pushed a rebase onto main, so be careful if you have any local changes.

@MattSturgeon MattSturgeon dismissed their stale review June 2, 2024 16:50

Resolved

MattSturgeon
MattSturgeon requested changes Jun 2, 2024
View reviewed changes
Copy link
Member

@MattSturgeon MattSturgeon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor description changes now, unless you disagree.
Also, should the commit/PR title use plugins/lsp/nil_ls to match the file/option names (underscore instead of hyphen)?

plugins/lsp/language-servers/nil_ls-settings.nix Outdated Show resolved Hide resolved
plugins/lsp/language-servers/nil_ls-settings.nix Outdated Show resolved Hide resolved
plugins/lsp/language-servers/nil_ls-settings.nix Outdated Show resolved Hide resolved
plugins/lsp/language-servers/nil_ls-settings.nix Outdated Show resolved Hide resolved
@GaetanLepage
Copy link
Member Author

Done !
I also changed the commit message.
But we should be renaming the module to be nil-ls. Can you do that @MattSturgeon please ?

@GaetanLepage
Copy link
Member Author

(in a separate PR though)

@GaetanLepage GaetanLepage requested a review from MattSturgeon June 2, 2024 17:21
MattSturgeon
MattSturgeon approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@GaetanLepage GaetanLepage merged commit 513b3c7 into nix-community:main Jun 2, 2024
55 checks passed
@GaetanLepage GaetanLepage deleted the nil-ls branch June 2, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattSturgeon MattSturgeon MattSturgeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaetanLepage @MattSturgeon