Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .version #1

Closed
wants to merge 1 commit into from
Closed

Create .version #1

wants to merge 1 commit into from

Conversation

maydayv7
Copy link

@maydayv7 maydayv7 commented Feb 7, 2022

This is because in lib.trivial.release the file .version is used which leads to complications when nixpkgs.lib is used with nixosConfigurations

This is because in [`lib.trivial.release`](https://github.com/nix-community/nixpkgs.lib/blob/58eabcf65e7dba189eb0013f86831c159e3b2be6/lib/trivial.nix#L167) the file `.version` is used which leads to complications when `nixpkgs.lib` is used with `nixosConfigurations`
@maydayv7
Copy link
Author

CC @blaggacao

@blaggacao
Copy link
Collaborator

blaggacao commented Feb 12, 2022

What is the complication?

I think in such cases, nixpkgs/lib is a better fit.

nixpkgs.lib should have no interface or knowledge of nixpkgs. It is meant to make the agnostic part of nixpkgs/lib available to a wider audience, without having to use nixpkgs proper.

Library functions that implicitly depend on nixpkgs are probably wrong here, but there doesn't seem to be a way to filter them out.

These functions could be moved out of ./lib upstream, or any other way of separating agnostic & non-agnostic library functions into different folders could be employed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants