Skip to content

Commit

Permalink
lib.modules: fix test line using empty "$@"
Browse files Browse the repository at this point in the history
Probably a missed left over from somewhere in
the commit 9420324.
As can be seen in that commit where this line was introduced,
"$@" was also just emptied by the last `set` call in line 169.
This line is currently valid, but breaks suddenly when somewhere earlier
a `set --` instruction is used in the future.
Neither in commit 9420324
nor in PR NixOS/nixpkgs#197547
have I found anything stating that this "defect" was intentional.
  • Loading branch information
Zocker1999NET committed Oct 5, 2024
1 parent 92c9b2e commit 60e543d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/tests/modules.sh
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ checkConfigError 'A submoduleWith option is declared multiple times with conflic

# _type check
checkConfigError 'Expected a module, but found a value of type .*"flake".*, while trying to load a module into .*/module-imports-_type-check.nix' config.ok.config ./module-imports-_type-check.nix
checkConfigOutput '^true$' "$@" config.enable ./declare-enable.nix ./define-enable-with-top-level-mkIf.nix
checkConfigOutput '^true$' config.enable ./declare-enable.nix ./define-enable-with-top-level-mkIf.nix
checkConfigError 'Expected a module, but found a value of type .*"configuration".*, while trying to load a module into .*/import-configuration.nix.' config ./import-configuration.nix
checkConfigError 'please only import the modules that make up the configuration' config ./import-configuration.nix

Expand Down

0 comments on commit 60e543d

Please sign in to comment.