docs(extra-files) add howto #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phaer
reviewed
Dec 19, 2024
docs/cli.md
Outdated
| @@ -36,8 +36,8 @@ Options: | |||
| * --stop-after-disko | |||
| exit after disko formatting, you can then proceed to install manually or some other way | |||
| * --extra-files <path> | |||
| path to a directory to copy into the root of the new nixos installation. | |||
| Copied files will be owned by root. | |||
| contents of local <path> are recursively copied and overwrites root (/) of the new NixOS installation. | |||
There was a problem hiding this comment.
Suggested change
| contents of local <path> are recursively copied and overwrites root (/) of the new NixOS installation. | |
| contents of local <path> are recursively copied to the root (/) of the new NixOS installation. Existing files are overwritten |
phaer
reviewed
Dec 19, 2024
docs/howtos/extra-files.md
Outdated
| When the files are extracted on the remote the copied data will be owned by | ||
| root. | ||
|
|
||
| ### Soft links |
There was a problem hiding this comment.
Nit: I think the term "symlinks" / "symbolic links" has won and woudl use that here
phaer
reviewed
Dec 19, 2024
docs/howtos/extra-files.md
Outdated
| $ root=$(mktemp -d) | ||
| $ sudo cp --verbose --archive --link --parents /etc/ssh/ssh_host_* ${root} | ||
| $ cp --verbose --archive --link /persist ${root} # --parents not needed for a full path | ||
| $ lsd --tree --long ${root} |
There was a problem hiding this comment.
Maybe remove the lsd call and just post the output as an example layout in another source block? Using non-standard tools in a howto without explaining/installing them could be confusing?
phaer
reviewed
Dec 19, 2024
|
Appreciate the feedback! Let me know if everything is addressed and I will squash. EDIT: nm there wasnt much to it, so just squashed. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a howto for
--extra-files#283