Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DocBook -> CommonMark #25

Merged
merged 1 commit into from
Mar 22, 2023
Merged

feat: DocBook -> CommonMark #25

merged 1 commit into from
Mar 22, 2023

Conversation

ryantm
Copy link
Collaborator

@ryantm ryantm commented Jun 12, 2021

Output is CommonMark with some syntax extensions:

  • DD lists
  • heading anchors

Output is CommonMark with some syntax extensions:
* DD lists
* heading anchors
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/happy-docsgiving/10214/28

@zimbatm
Copy link
Member

zimbatm commented Jan 6, 2023

@ryantm this PR looks ready isn't it?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-03-14-documentation-team-meeting-notes-32/26351/1

@pennae
Copy link
Contributor

pennae commented Mar 18, 2023

we would like to propose that this PR be updated to support examples as in NixOS/nixpkgs#220116, which is very close to how pandoc represented examples (but can actually reconstruct a docbook title tag). that's the update discussed in the docs team meeting notes.

@asymmetric
Copy link
Contributor

@infinisil you're looking into updating this right?

@ryantm
Copy link
Collaborator Author

ryantm commented Mar 20, 2023

@ryantm this PR looks ready isn't it?

I've been testing the output of it in my version of the Nixpkgs manual for over a year now. https://ryantm.github.io/nixpkgs/functions/library/asserts/#sec-functions-library-asserts

So, yes, probably.

@asymmetric
Copy link
Contributor

asymmetric commented Mar 20, 2023

I propose we merge this and address any further needs in follow-up PRs, since a) @ryantm has tested it for a long time and it works; and b) he's looking for new maintainers, so this could be a nice handover line.

@ryantm ryantm merged commit f5e75bf into nix-community:master Mar 22, 2023
@ryantm ryantm deleted the cm branch March 22, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants