fix: erroneous architecture for darwin (macos) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doronbehar
approved these changes
Nov 28, 2024
|
Hey all, since the issue is blocking the packaging NixOS/nixpkgs#359514 I will proceed to self-merge this next week if there is no objection, but feel free to stop me anytime! @makefu @Artturin |
|
Since I see you have permissions here and you are active, a 2.0.1 release would be nice now :). |
|
hey, and sorry for not replying. The fix is fine for me, also the release of the new version :) |
|
Could anyone please make a 2.0.1 release for Nixpkgs? |
I made the 2.0.1 release: https://github.com/nix-community/hydra-check/releases/tag/v2.0.1 |
|
Thanks. Updated the Nixpkgs PR and marked it as ready for review: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #54. However, this is a dirty hack... I wonder if there is a way to obtain the usual platform double (e.g.
aarch64-darwin) in rust. Searching...Friendly ping @doronbehar for review & testing!
Update: another solution is to read the target triple from a
build.rsscript, and then reduce it to a target double. But that seems too much trouble... I think I will stick to the current solution for now.