Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess channel better #40

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Conversation

doronbehar
Copy link
Contributor

Until now, when I delved into the code, I always got confused with the channels, jobsets, and the architectures. It always annoyed me how these terms are intermingled, and why e.g darwin doesn't use the unstable jobset, and what is the difference between it and master...

I also felt as if hydra-check doesn't help me a lot to hide all of these details, because whenever I wanted to check whether a package already fails on Darwin on hydra, I had to open the README, which up until now didn't include a single darwin architecture example, and try out the different jobsets...

Anyway, with the changes here, hopefully users won't be frustrated as I was :). The first 2 commits change only the docs and the --channel help text - they make the distinction between channels and jobset a bit clearer. The last commit makes the --arch choice affect the default jobset chosen, where darwin is taken into special consideration.

This makes it easier to realise what is the jobset parsed by the default
channel, and the architecture.
Copy link
Member

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It adds the architecture to the jobset guess which is cool i think.
reasonable changes, lgtm.

@makefu makefu merged commit 476e6cc into nix-community:master Oct 7, 2023
@doronbehar
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants