aerospace: add module #6279
aerospace: add module #6279
Conversation
damidoug
force-pushed
the
aerospace
branch
2 times, most recently
from
3b613fb to
c1ecfb2
Compare
|
Hey, when will this be available? |
|
@Lalit64 just waiting someone to merge it, but in this time you can use my repo on aerospace branch to test, if you are using flakes just change the home manager url to my repo. |
|
What's the difference between this and the nix-darwin module |
nix-darwin module is a |
|
why services? its for home-manager. |
|
|
Because he's using launchd integration for auto-start, im not using it. |
That is what I mean? |
They answered a question about the difference between this PR and the existing nix-darwin module.. |
| @@ -79,6 +79,12 @@ | |||
| github = "considerate"; | |||
| githubId = 217918; | |||
| }; | |||
| damidoug = { | |||
There was a problem hiding this comment.
This should be a separate commit.
There was a problem hiding this comment.
@khaneliman the diference its for home-manager, in my case I dont use nix-darwin just the nix + home-manager. i want to keep all my apps on home-manager, so i can use the same flake file on linux, darwin etc... just installing nix+home-manager.
There was a problem hiding this comment.
I saw some news modules merged with the manitainers in the same commit, for this reason i kept in the same.
There was a problem hiding this comment.
@khaneliman the diference its for home-manager, in my case I dont use nix-darwin just the nix + home-manager. i want to keep all my apps on home-manager, so i can use the same flake file on linux, darwin etc... just installing nix+home-manager.
Again, all we are doing is explaining the reason for a comment above. No need to justify it again.
I saw some news modules merged with the manitainers in the same commit, for this reason i kept in the same.
Still is a best practice for logical commits.
There was a problem hiding this comment.
what is missing to approve this PR?
Description
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC