-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gradle: add module #4667
gradle: add module #4667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my first contribution to the nix eco system. I'm still learning nix. Hope this makes sense!
Would it be possible to add another setting for customizing the dot directory? The environment variable |
@liff I'll have a look into both your suggestions. Thank you for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liff This is still WIP but I addressed your comments. PTAL.
I'm still not happy with the way init scripts are handled. I think it would be better if the user could either define them inline or reference a file that is copied to the store. But I don't know how to define the type for the option. Can you give me some pointers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of programs.gradle.home
should be used for the location of the generated files.
bcc4b73
to
2f0002f
Compare
@liff this is now ready for the final review / merge. Thank you for your support. I learned a lot along the way. ❤️ |
e2e0661
to
7dfdd04
Compare
@liff anything missing in order to get this merged? |
Looks good to me, but I lack the power to merge 😔 |
@liff do you know by any chance who to ping to get this merged? |
I guess it would be @rycee by default? Or you could ask on the IRC channel. It occurred to me that since this is a new module, perhaps it’s worthy of a news entry. New modules usually seem to get one. |
Thanks for the contribution! I've added a bunch of mostly stylistic comments. The most important is to reduce the test closure to avoid GBs of downloads whenever the tests run 🙂 |
5264c9f
to
4131651
Compare
@rycee I think I addressed all your comments. Previously the code aggregated all init scripts in a store directory using I also added a news entry. |
4131651
to
e00e179
Compare
Introduces a new program called gradle for managing files stored in the home directory by the [Gradle Build Tool](https://gradle.org). Gradle uses the $HOME/.gradle folder for all it's configuration. Features of the new program module are: - Automatically setting programs.java.enable = true to make a Java installation available for running Gradle. - Specifying an alternate Gradle home directory - Setting of abitrary values for gradle.properties stored inside the Gradle home directory. - Defining init scripts that will be linked into the init.d inside the Gradle home directory. Co-authored-by: Olli Helenius <[email protected]> Co-authored-by: Robert Helgesson <[email protected]>
e00e179
to
433120e
Compare
Thanks! Merged to master now 🙂 |
This is what was added in nix-community/home-manager#4667
Description
Introduces a new program called gradle for managing files stored in the
home directory by the Gradle Build Tool. Gradle
uses the $HOME/.gradle folder for all it's configuration.
Features of the new program module are:
installation available for running Gradle.
Gradle home directory.
linked to init.d inside the Gradle home directory or by specifying
a list of init script definitions.
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC