Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dunst: make icon_path extensible #2097

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

ncfavier
Copy link
Member

Description

This makes settings.global.icon_path a separatedString ":" so that the user can add their own paths.

I need this because the current icon_path setting is quite flaky (but I don't think there's a better way apart from implementing the icon theme specification, or waiting until dunst does).

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

@ncfavier ncfavier requested a review from rycee as a code owner June 11, 2021 09:21
Copy link
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

modules/services/dunst.nix Outdated Show resolved Hide resolved
modules/services/dunst.nix Show resolved Hide resolved
@sumnerevans sumnerevans requested a review from berbiche June 12, 2021 16:02
@berbiche berbiche merged commit 3aa479d into nix-community:master Jun 17, 2021
@berbiche
Copy link
Member

Tested locally 👍

@ncfavier ncfavier deleted the dunst-icon-path branch June 17, 2021 01:06
@ncfavier
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants