Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xsession.pointerCursor: .icons file for AwesomeWM #2084

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

league
Copy link
Collaborator

@league league commented Jun 7, 2021

closes #2081

Description

Writes the file ~/.icons/default/index.theme, which allows AwesomeWM (perhaps others?) to use the pointerCursor setting.

Checklist

  • Change is backwards compatible. (Unless a user is writing that file from their own config.)

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example. (There isn't a test case for this module yet.)

  • Commit messages are formatted like (I didn't use a long description, but referenced the reported issue instead)

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

Copy link
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Seems harmless.

@berbiche berbiche merged commit aa36e2d into nix-community:master Jun 7, 2021
@lovesegfault
Copy link
Contributor

This broke my setup as I now get this

error: builder for '/nix/store/vbfgzglpq417kvkhs12ibz7778s4mjrl-home-manager-files.drv' failed with exit code 1;
       last 1 log lines:
       > Error installing file '.icons/default/index.theme' outside $HOME

Unclear to me why though.

@berbiche
Copy link
Member

This broke my setup as I now get this

error: builder for '/nix/store/vbfgzglpq417kvkhs12ibz7778s4mjrl-home-manager-files.drv' failed with exit code 1;
       last 1 log lines:
       > Error installing file '.icons/default/index.theme' outside $HOME

Unclear to me why though.

Is it possible your folder .icons is a symlink to a folder outside home?

@lovesegfault
Copy link
Contributor

This broke my setup as I now get this

error: builder for '/nix/store/vbfgzglpq417kvkhs12ibz7778s4mjrl-home-manager-files.drv' failed with exit code 1;
       last 1 log lines:
       > Error installing file '.icons/default/index.theme' outside $HOME

Unclear to me why though.

Is it possible your folder .icons is a symlink to a folder outside home?

As far as I can tell .icons is being generated by home-manager

❯ ls $HOME/.icons
Permissions Size User     Date Modified Name
lrwxrwxrwx    77 bemeurer  9 Jun 22:46  default -> /nix/store/mg4hkybs1qijhapy12nqm6sgn70jf40z-home-manager-files/.icons/default/

@league
Copy link
Collaborator Author

league commented Jun 10, 2021

Interesting… I didn't see anywhere in the current home-manager source that home.file.".icons/…" was being set. So it would help to figure out where this comes from.

It looks like .icons/default/ is indeed a directory, but the conflicting module is linking the whole directory rather than individual files which would make it (more likely) possible to merge them. What's in the directory – is it also index.theme or other files?

@lovesegfault
Copy link
Contributor

❯ tree $HOME/.icons
/home/bemeurer/.icons
└── default -> /nix/store/mg4hkybs1qijhapy12nqm6sgn70jf40z-home-manager-files/.icons/default
❯ tree -L 1 /nix/store/mg4hkybs1qijhapy12nqm6sgn70jf40z-home-manager-files/.icons/default
/nix/store/mg4hkybs1qijhapy12nqm6sgn70jf40z-home-manager-files/.icons/default
├── 16x16
├── 22x22
├── 24x24
├── 256x256
├── 32x32
├── 48x48
├── 512x512
├── 64x64
├── 8x8
├── 96x96
├── cursors
├── icon-theme.cache
├── index.theme
├── scalable
└── scalable-up-to-32

@berbiche
Copy link
Member

I'll open a PR reverting this in the meantime.

@lovesegfault
Copy link
Contributor

This is still failing for me, I'll make a reversal PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcursor module not follow XDG specification
3 participants